[uv] cleaning up build files#8517
Merged
Merged
Conversation
Collaborator
|
What about adding |
Contributor
Author
Makes sense will update the docs for the same as well |
madelinevibes
added
the
Type::Bug
king-11
force-pushed
the
king-11/uv-cleanup
branch
from
063e477 to
fd6f924
Compare
Contributor
Author
|
@daywalker90 have updated the docs also now |
for python 3.3+ we don’t need an __init__.py at namespace package to allow extensions instead we can just get rid of them
duplicate definition isn’t required as we already defined them at workspace level sources
prevent updates to lock file which might leave working directory dirty resulting in a modded cln version build
rustyrussell
force-pushed
the
king-11/uv-cleanup
branch
from
cf087aa to
3e0f23b
Compare
Closed
Contributor
|
Fixes: #8532 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
25.09 FREEZE July 28TH: Non-bugfix PRs not ready by this date will wait for 25.12.
RC1 is scheduled on August 11th
The final release is scheduled for September 1st.
we can get rid of
__init__.pyfiles at namespace package level as its only required to support python 2 and beyond python 3.3+ we would be good.we had also declared the package sources twice which are already declared at workspace root level. so removing the duplicate source entries.
Changelog-None
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: